Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to loadRelatedObjects #19407

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove call to loadRelatedObjects

Before

$ids['paymentProcessor'] = $paymentProcessorID;
      $contribution->loadRelatedObjects($input, $ids);

but the loaded ids are never used

After

poof

Technical Details

None of the ids loaded in this function are used anymore so we can remove the call to it
The only reference to ids after this line is to contribution page id, which is loaded earlier

Comments

Test cover in AuthorizenetIPNTest class is pretty solid

None of the ids loaded in this function are used anymore so we can remove the call to it
The only reference to ids after this line is to contribution page id, which is loaded earlier
@civibot
Copy link

civibot bot commented Jan 17, 2021

(Standard links)

@civibot civibot bot added the master label Jan 17, 2021
@seamuslee001
Copy link
Contributor

Looks good to me merging

@seamuslee001 seamuslee001 merged commit 9a4884e into civicrm:master Jan 18, 2021
@seamuslee001 seamuslee001 deleted the anet branch January 18, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants