[REF] Param simplification

[eileenmcnaughton]

Overview

On looking at this param it can only be reached if recur->id is set and the other criteria can be
squashed to an empty check

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

$autoRenewMembership = FALSE;
      if ($recur->id &&
        isset($ids['membership']) && $ids['membership']
      ) {
        $autoRenewMembership = TRUE;
      }

Technical Details

$autoRenewMembership = !empty($ids['membership'])

Comments
----------------------------------------

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Makes sense MOP

[eileenmcnaughton]

api.v4.Entity.ConformanceTest.testConformance with data set "Relationship" is a new intermittent false-fail due to @colemanw recently adding a pseudoconstant - the issue is the test creates 'random' relationships, some of which are invalid now. Merging & ignoring