Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move instantiation of Order class to earlier in function #19402

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 17, 2021

Overview

[REF] Move instantiation of Order class to earlier in function

This is part of making the Order object and it's methods available to the non-renewal
form which has the same amount calculation bug the class is used to fix.

Note the Order class is an internal class not the order api which we do wish to switch this
form to using

Before

Functionality unavailable to new member form, only renewal

After

Available, not yet used

Technical Details

This has test cover in the renewal form test class

Comments

@civibot
Copy link

civibot bot commented Jan 17, 2021

(Standard links)

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton force-pushed the mem_form branch 2 times, most recently from d41058b to e995223 Compare January 18, 2021 06:03
This is part of making the Order object and it's methods available to the non-renewal
form which has the same amount calculation bug the class is used to fix.

Note the Order class is an internal class not the order api which we do wish to switch this
form to using
@mattwire mattwire merged commit 459192b into civicrm:master Jan 18, 2021
@eileenmcnaughton eileenmcnaughton deleted the mem_form branch January 18, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants