Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pledge to not use pass-by-reference #19400

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Fix pledge to not use pass-by-reference #19400

merged 1 commit into from
Jan 18, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 17, 2021 •
edited
Loading

Overview

Fix pledge to not use pass-by-reference

Before

BAOs receive params as a reference, somehting we have been deprecating

After

poof. Also tangential tidy up

Technical Details

We have deprecated this out of BAO classes

Comments

@civibot
Copy link

civibot bot commented Jan 17, 2021

(Standard links)

@civibot civibot bot added the master label Jan 17, 2021
@eileenmcnaughton eileenmcnaughton force-pushed the pledge_ref branch 2 times, most recently from 30947f1 to 7160bf3 Compare January 17, 2021 19:57
eileenmcnaughton
eileenmcnaughton commented Jan 17, 2021
View reviewed changes
CRM/Pledge/BAO/Pledge.php
*/
public static function create(&$params) {
// FIXME: a cludgy hack to fix the dates to MySQL format
$dateFields = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been needed for some years

@eileenmcnaughton eileenmcnaughton force-pushed the pledge_ref branch 3 times, most recently from 57907be to a4c85ec Compare January 17, 2021 22:02
@seamuslee001
Copy link
Contributor

Makes sense MOP

@eileenmcnaughton
Fix pledge to not use pass-by-reference
45ae836 
We have deprecated this out of BAO classes
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit 98cd4c3 into civicrm:master Jan 18, 2021
@seamuslee001 seamuslee001 deleted the pledge_ref branch January 18, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001