Tabbed interface for organizing afforms by type #19395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
retest this please |
|
Looks good - when looking at this I think putting the title left of the name would make the view more readable |
This allows an afform af-fieldset to function without a containing af-form or reference to af-entity Instead it can directly contain an api-entities tag to assist filling field metadata. The search extension then adds that tag based on the search parameters. This also eliminates the need to pass in filters to the search display directly (though it still supports that), as it will infer them from the presence of an af-fieldset.
|
This is extension-only code. Merging to move things along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This creates afform types and a tabbed interface in the Admin section, and adds support for embedding search displays into afform fieldsets.
Before
Single form type
After
Multiple types of forms.
Afforms now support embedded search displays and are able to add filter fields for all entities in that display.
Comments
This gets us a long way toward solid integration between Afform and Search Kit. The remaining step is GUI support for composing filter fields for search-based afforms.