distmaker - Don't require dummy config file for building Joomla #19357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEFORE: To run distmaker and produce Joomla ZIPs, you need to create a dummy settings file. For example, this is how `cividist` does it: https://github.com/civicrm/civicrm-buildkit/blob/v19.07.0/bin/cividist#L119-L121 It seems that is just a long-winded way of setting up the Civi classloader. (It wouldn't make sense to use any other Civi services this is a pre-bootstrap environment.) AFTER: The dummy file is neither needed nor used. We just get the classloader directly.
…tion Makes this much easier to read. Honestly, I'm not sure it should even be checking $_SERVER like this -- $argv is probably enough, and I suspect that $_SERVER won't give the expected values in most PHP environments.
|
(Standard links)
|
|
looks fine to me merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This addresses a quirky requirement in the workflow for building Civi-Joomla.
Before
To run distmaker and produce Joomla ZIPs, you need to create two dummy files.
For example, this is how
cividistdoes it: https://github.com/civicrm/civicrm-buildkit/blob/v19.07.0/bin/cividist#L119-L121It seems that is just a long-winded way of setting up the Civi classloader. (It wouldn't make sense to use any other Civi services as this is a pre-bootstrap environment.)
After
The dummy file is neither needed nor used. We just get the classloader directly.