Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - code refactoring for angular best practices #19352

Merged
merged 13 commits into from
Jan 14, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 9, 2021

Overview

Reorganizes the angular code for the Afform Admin extension to follow best practices.

Technical Details

Renamed afform-gui extension to afform_admin
Refactors a bunch of directives into angular components

Comments

Extension reorganization is with an eye toward folding the afform_html extension into the gui extension.

@civibot
Copy link

civibot bot commented Jan 9, 2021

(Standard links)

@civibot civibot bot added the master label Jan 9, 2021
@eileenmcnaughton
Copy link
Contributor

I'm going to merge this now as it's a piece of work @colemanw is doing this cycle & we are committed to doing more testing throughout the cycle

@eileenmcnaughton eileenmcnaughton merged commit 6fea2a8 into civicrm:master Jan 14, 2021
@eileenmcnaughton eileenmcnaughton deleted the afformRef branch January 14, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants