Correctly check button to allow duplicate contact saving from profiles #19328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@colemanw are you able to rebase this for 5.33? |
|
tested and this fixes the problem. |
…aving from profiles
520c703 to
f585b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the regression described in https://lab.civicrm.org/dev/core/-/issues/2287
Before
Popup profiles failed to save duplicate contacts.
After
Popup profiles correctly save duplicate contacts when user chooses to.
Technical Details
Changing the button from
type=submittotype=buttonchanged the values submitted back to the server. The value for the button came back as an empty string instead of the button label because submit elements have a value but buttons do not.