Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit box-sizing to crm-flex-box style #19325

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 6, 2021

Overview

This ensures consistent box sizing when using the new crm-flex-box css class, for consistency with or without Bootstrap 3.

Technical Details

Bootstrap 3 sets this box-sizing value explicitly. We should too.

@civibot
Copy link

civibot bot commented Jan 6, 2021

(Standard links)

@civibot civibot bot added the master label Jan 6, 2021
@eileenmcnaughton
Copy link
Contributor

@colemanw I'm inclined to merge this before the rc is cut due it presumably playing into other theming changes. However, this isn't my area - is there someone who is likely to weigh in on this or some other reason I should feel comfortable merging?

@colemanw
Copy link
Member Author

colemanw commented Jan 6, 2021

Well, it doesn't currently make any difference. It's more like future-proofing so we don't end up with theming ambiguity.
I checked the dashboard page and it looks exactly the same before/after.

@seamuslee001
Copy link
Contributor

This seems ok to me merging

@seamuslee001 seamuslee001 merged commit e38ebcd into civicrm:master Jan 13, 2021
@seamuslee001 seamuslee001 deleted the cssFix branch January 13, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants