-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#2028 Add in a status check for checking if the wkhtmltopdf p… #19311
Conversation
(Standard links)
|
19bbcd6
to
685547f
Compare
…ackage is installed in the expected location, Also ensure if it isn't then the pdf generation falls back on the current default which is DOMPDF
685547f
to
6bbe0cf
Compare
|
I've always wondered... why do we need to store the path? Can't we look it up with a command like |
@colemanw I presume because |
Good thought but it might not be in path. And on windows that would fail. |
Oh oh we're starting to think alike. |
Regression Gitlab, https://lab.civicrm.org/dev/core/-/issues/2478 |
…ackage is installed in the expected location, Also ensure if it isn't then the pdf generation falls back on the current default which is DOMPDF
Overview
As per the lab issue a fatal error can be generated when trying to send out a Participant confirmation if your attaching the PDF onto it and your using wkhtmltopdf according to the settings but the package isn't installed for some reason.
Before
Hard fail on PDF generation
After
Status check and a softer fail with a fallback to using DOMPDF
ping @eileenmcnaughton @demeritcowboy @monishdeb