dev/core#766 fix failure to save custom data on template-based-event

[eileenmcnaughton]

Overview

https://lab.civicrm.org/dev/core/-/issues/766

Before

custom data fails to save

After

saves

Technical Details

I decided that this was not a regression but that the fix was trying to format custom data in a way that was needed for the custom data retrieved from the template defaults but not for submitted custom data so I moved it

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[agileware-justin]

This change caused regression, https://lab.civicrm.org/dev/event/-/issues/58

[eileenmcnaughton]

Dang whackamole

[agileware-justin]

And have re-opened https://lab.civicrm.org/dev/core/-/issues/766 as well, sorry about that.

[eileenmcnaughton]

Yeah - we tend to lower the bar re tests for regressions - in part because of the rush & in part because the person doing the fix under pressure is generally not the person who broke it (this PR was perceived as a regression & hence worked on but ultimately it wasn't clear it was) - however we definitely have to make sure we fix this with a test - even if it delays it by a release given the history