Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove unreachable code #19279

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 28, 2020

Overview

[REF] Remove unreachable code

Before

This code was copied from the previously shared function & supports some really weird stuff for the contribution form.

I tested & was unable to reach this from the back office membership form - note it is only reachable
when processing recurring which in turn relies on the membership type being configured and the
processor. It seems that recurring is not available with price sets

After

poof

Technical Details

This whole function was copied from the function on the front end form & then the parts (almost all) that are irrelevant removed. With this gone it does 2 things

  • creates the recurring
  • creates the contribution

The second of these actually also needs to go as there is handling later on to cope with the fact it has been done here rather than further in

Comments

This code was copied from the previously shared function & supports some really weird stuff for the contribution form.

I tested & was unable to reach this from the back office membership form - note it is only reachable
when processing recurring which in turn relies on the membership type being configured and the
processor. It seems that recurring is not available with price sets
@civibot
Copy link

civibot bot commented Dec 28, 2020

(Standard links)

@civibot civibot bot added the master label Dec 28, 2020
@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, merging this.

@yashodha yashodha merged commit 3adb663 into civicrm:master Dec 29, 2020
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha

@eileenmcnaughton eileenmcnaughton deleted the go_mem branch December 29, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants