dev/core#2263 Do not try and store items in the session if the sessio…

[seamuslee001]

…n is currently empty

Store the locale in the session even if we are in a single lingual instance

Overview

This aims to fix an issue where by if you have multiple languages enabled on your civicrm instance the KcFinder breaks because the session is tried to written to before Drupal has booted

Before

1. Create a Drupal test site
2. Enable multiple languages
3. Try to access KCFinder say from managing a contribution page and get errors

After

The above works

Technical Details

There is more investigation information found on the alternate PR #19242. However this to me tries to target the actual underlying source of the problem where was that feels like it is just putting a bandaid on the issue

ping @haystack @kainuk @mlutfy

Are any of you able to test this and let me know if it works for you?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kainuk]

Hi @seamuslee001, I just tested this on my development database and on the site of the customer. It works fine, thanks. I will close my alternative PR

[eileenmcnaughton]

merging based on @kainuk's testing & looking at the code this looks like it should be merged. I've added 'merge-ready' to give others a couple of days to weigh in

[mlutfy]

Looks good!