Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#2244 Simplify and consistently apply checking of whether fin… #19175

Merged
merged 1 commit into from
Dec 11, 2020
Merged

dev/core#2244 Simplify and consistently apply checking of whether fin… #19175

merged 1 commit into from
Dec 11, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

port of #19173

@eileenmcnaughton
dev/core#2244 Simplify and consistently apply checking of whether fin…
c93aa26 
…ancial acls are enabled

Per https://lab.civicrm.org/dev/core/-/issues/2244 the move of some handling to this function
did not consistently include an early return when the setting is toggled off.

Eventually there will be no setting - just 'is this extension enabled or not' but
in the transition we need this. The new version is easier to copy and paste :-)
and uses a function in the extension. The function in the main code base is
mostly a lot of code to handle the way the setting used to be stored & it
could just check the setting too now
@civibot
Copy link

civibot bot commented Dec 11, 2020

(Standard links)

@civibot civibot bot added the 5.32 label Dec 11, 2020
@seamuslee001 seamuslee001 merged commit 001179e into civicrm:5.32 Dec 11, 2020
@seamuslee001 seamuslee001 deleted the 532 branch December 11, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001