Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous elses #19168

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 10, 2020

Overview

This looks like a huge code change but it's just removing meaningless elses and reformatting

Before

Constructs like

if ($a = 1) {
  return;
}
else {
  // do the thing
}

After

if ($a = 1) {
  return;
}
 // do the thing

Technical Details

Comments

Use w=1 to see this better https://github.com/civicrm/civicrm-core/pull/19168/files?w=1

This looks like a huge code change but it's just removing meaningless elses and reformatting
@civibot
Copy link

civibot bot commented Dec 10, 2020

(Standard links)

@civibot civibot bot added the master label Dec 10, 2020
@seamuslee001
Copy link
Contributor

This looks fine to me merging

@seamuslee001 seamuslee001 merged commit a99ecd4 into civicrm:master Dec 11, 2020
@seamuslee001 seamuslee001 deleted the dup_error branch December 11, 2020 00:55
This was referenced Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants