Manage Event: avoid E_NOTICE in smarty #19137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
To reproduce:
When using a dev environment that displays notices, or throws exceptions, it will fail to load the page.
Technical Details
The associated Smarty tpl has "if" statements in other places to check against empty values, but it throws a notice on this:
whereas in other places, the code does this:
I figured it was preferable to assign upstream, rather than add "ifs" in smarty.