Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Deprecate passing a blank currecny to CRM_Utils_Money::format a… #19099

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

seamuslee001
Copy link
Contributor

…nd also update function call to remove at least one usage of money_format

Overview

This updates the call for when CRM_Utils_Money::format is passed with asking for just the number to use an appropriate internal money formatting function instead of the deprecated money_format function. It also deprecates passing in ' ' a blank string as a param for $currency.

Before

$currency = ' ' not deprecated and money_format used in at least 1 place

After

$currecny = ' ' deprecated and money_format only used in one place

ping @eileenmcnaughton @mattwire

…nd also update function call to remove at least one usage of money_format
@civibot civibot bot added the master label Dec 3, 2020
@civibot
Copy link

civibot bot commented Dec 3, 2020

(Standard links)

@eileenmcnaughton eileenmcnaughton added the merge ready PR will be merged after a few days if there are no objections label Dec 3, 2020
@eileenmcnaughton
Copy link
Contributor

This seems right to me - I'm going to leave overnight in case @mattwire sees any issues but it feels like a good time to merge as the rc has just been cut

@seamuslee001
Copy link
Contributor Author

Its been a few days and matt hasn't responded so am going to merge this

@seamuslee001 seamuslee001 merged commit 046e365 into civicrm:master Dec 7, 2020
@seamuslee001 seamuslee001 deleted the ref_money_format_update branch December 7, 2020 23:14
@eileenmcnaughton
Copy link
Contributor

yep - I think it had it's merge-ready spell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants