Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Add in an Emoji test for APIv3 as per Eileen's PR #19078

Merged
merged 1 commit into from
Dec 1, 2020
Merged

[NFC] Add in an Emoji test for APIv3 as per Eileen's PR #19078

merged 1 commit into from
Dec 1, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

This adds in a unit test as per #18918 but for APIv3 where as that only covered APIv4

Before

No Test

After

Test

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Nov 30, 2020

(Standard links)

@civibot civibot bot added the master label Nov 30, 2020
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 yeah - it doesn't work - it's the query object. I figured a bit of incentive to start moving to apiv4 wasn't a bad thing & I'm really trying to spend less time on the query object

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton it passed for me locally

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton well this has passed as per Jenkins

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 well I'm happy to merge - a passing test is a passing test

@eileenmcnaughton eileenmcnaughton merged commit 5166db4 into civicrm:master Dec 1, 2020
@eileenmcnaughton eileenmcnaughton deleted the emoiji_test_api3 branch December 1, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton