Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schema metadata for Search Kit #19075

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 30, 2020

Overview

Improves the relevance of entities listed in Search Kit by:

  1. Excluding entities from disabled components.
  2. Designating some entities as not searchable.

Before

  1. All entities returned from APIv4 Entity::get().
  2. No metadata about which entities are searchable.

After

  1. APIv4 Entity::get() excludes entities from disabled components.
  2. Search kit excludes API entities annotated @searchable false.

@civibot
Copy link

civibot bot commented Nov 30, 2020

(Standard links)

@civibot civibot bot added the master label Nov 30, 2020
@colemanw
Copy link
Member Author

@seamuslee001 @eileenmcnaughton @totten this PR is mostly just adding metadata. It'll go stale quickly.

@seamuslee001
Copy link
Contributor

Makes sense to me MOP

@seamuslee001
Copy link
Contributor

@colemanw test fail relates

api\v4\Entity\ConformanceTest::testEntitiesProvider

@colemanw
Copy link
Member Author

Right. That's because the test suite doesn't enable all components by default. Should be fixed now.

@seamuslee001 seamuslee001 merged commit ddaa3ff into civicrm:master Dec 1, 2020
@seamuslee001 seamuslee001 deleted the searchable branch December 1, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants