Remove unreachable customGroup section in online event receipt

[eileenmcnaughton]

Overview

Remove unreachable customGroup section in online event receipt

Before

Section for including custom fields when assigned as $customGroup - but I can find no evidence nor think of a reason why it would be assigned.

After

The section is removed from the template - meaning it would not be present on new installs

Technical Details

After digging into #18697 I came to the
conclusion that currently both the online & offline event receipts have
sections for custom profiles and custom data (marked as customGroup).

The profiles are only assigned from the online flow and the data only from the offline
flow so in each receipt template one is unused.

I agree with the discussion on https://lab.civicrm.org/dev/core/-/issues/2076
that suggests that since every event has (potentially) assigned profiles
we could use those in both scenarios and never use the generic 'customGroup'.
The situation is less clear for contributions (where there is no profile
if there is no contribution page). Thus, I am inclined
to remove customGroup from the offline template too, after fixing to
include the profiles. However, there are additional
steps to get to the point where that is doable - at this stage I think
we CAN remove it from the online template because I cannot find anywhere
in the code where customGroup is assigned in that flow, nor logically
think of any reason other than copy and paste for it

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

Agree with the patch and tested on local to see if online event receipt passes the customGroup to message template, but not true. Confirmed that its safe to remove the unused section. Hence merging it.