Fix dev/core#2215 & remove the tab selection inline script from TabHeader.tpl

[colemanw]

Overview

Removes some redundant code that was selecting the default tab twice. https://lab.civicrm.org/dev/core/-/issues/2215

Before

Default tab set by tabHeader.js and then set again (sometimes incorrectly) by TabSelected.tpl.
In the case of Campaigns/Surveys, it was incorrect.

After

Default tab set just once.

Technical Details

This mostly gets the logic for selecting default tab out of the tpl. The final step would be to delete CRM/common/TabSelected.tpl and all references to it and the variables it uses.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I did an r-run of this and confirmed that it works for Contribution Pages and fixes the Campaign Dashboard links. @colemanw does this need to be against the RC or is this regression old enough it isn't 'recent'?

[colemanw]

I think this regressed about 6 months ago due to #17066
Probably doesn't need to be in the RC. It would be good to make sure this still works with Events as that was the intended fix in #17066.

[mattwire]

@colemanw This seems to break messagetemplates admin UI:

[colemanw]

@mattwire - indeed, that screen was relying on a messy artifact of TabSelected.tpl - in setting the default tab it was actually initializing the tabs!
Update: woa, that page actually had the <div id="mainTabContainer"> element twice! Once in the template and then including TabHeader.tpl added it a second time. It's a wonder it functioned at all.

[seamuslee001]

@colemanw test fail looks related CRM_Contribute_Form_ContributionTest::testOpeningWidgetAdminPage

[eileenmcnaughton]

@mattwire @seamuslee001 have the issues been addressed now?

[mattwire]

Yes, thanks @colemanw

[demeritcowboy]

The removal of {include file="CRM/common/TabSelected.tpl" defaultTab="settings"} from templates/CRM/common/TabHeader.tpl makes the tabs on the extension admin screen stop being tabs (https://lab.civicrm.org/dev/core/-/issues/2233). Since putting it back sounds undesirable, any thoughts?

[mattwire]

@demeritcowboy I knew there was somewhere else that broke when stuff changed! I think @colemanw is on top of how this is meant to work and we probably need a small PR to fix the extensions admin screen?

[mattwire]

@colemanw @demeritcowboy See #19130