Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Simplify sendNotification determination #19054

Merged
merged 1 commit into from
Nov 25, 2020
Merged

[REF] Simplify sendNotification determination #19054

merged 1 commit into from
Nov 25, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Simplify sendNotification determination

Before

Determination distributed over a switch

After

Determination done at point of use

Technical Details

I have used the raw url value look up rather than the variable so the whole code chunk can be moved

Comments

@civibot
Copy link

civibot bot commented Nov 25, 2020

(Standard links)

@civibot civibot bot added the master label Nov 25, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

Looks good to me

@seamuslee001 seamuslee001 merged commit b14f299 into civicrm:master Nov 25, 2020
@seamuslee001 seamuslee001 deleted the pp1 branch November 25, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001