[REF] Remove excess handling around contact_id

[eileenmcnaughton]

Overview

[REF] Remove excess handling around contact_id

The removed code was formerly in a shared function. On looking the
getIDS actually just gets the contact id from the contributionRecur
object & every thing else is extraneous

Before

Lotsa code - not a lot of action

After

Poof

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[seamuslee001]

Jenkins re test this please

[seamuslee001]

@eileenmcnaughton test fails relate here

CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurNoReceipt
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccess
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccessMultiAuthNetProcessor
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccessSuppliedReceiveDate
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccess
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccessNoLeakage
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccessNoLeakageOnlineThenOffline

[eileenmcnaughton]

Yep - looks like there were a couple of other unnecessary references to it

[seamuslee001]

changes look fine to me merging