Delete outdated/unused crmExample Angular module #19049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Deletes some unused test Angular code.
Technical Details
This gets us one step closer to being able to autoload core Angular modules via
glob()
.Comments
I don't have anything against example code. But if we were to have an example Angular module IMO it should be:
Since this example module is outdated, IMO it would require a complete rewrite to make it useful. And in the meantime, it's taking up space and making autoloading of core modules via
glob()
more complicated.