Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete outdated/unused crmExample Angular module #19049

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 25, 2020

Overview

Deletes some unused test Angular code.

Technical Details

This gets us one step closer to being able to autoload core Angular modules via glob().

Comments

I don't have anything against example code. But if we were to have an example Angular module IMO it should be:

  1. Updated with latest best-practices (components, standalone base-page, bind-to-controller, bootstrap3)
  2. Packaged as an extension, like https://lab.civicrm.org/extensions/api4example/.

Since this example module is outdated, IMO it would require a complete rewrite to make it useful. And in the meantime, it's taking up space and making autoloading of core modules via glob() more complicated.

@civibot
Copy link

civibot bot commented Nov 25, 2020

(Standard links)

@civibot civibot bot added the master label Nov 25, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@colemanw
Copy link
Member Author

Retest this please

@eileenmcnaughton eileenmcnaughton merged commit 0d1fb08 into civicrm:master Nov 26, 2020
@eileenmcnaughton eileenmcnaughton deleted the crmExampleGone branch November 26, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants