[REF] Decouple crmD3 angular module from CiviMail

[colemanw]

Overview

Makes the D3 graphing library load in a more standard way.

Before

The crmD3 module was being conditionally declared based on whether CiviMail is enabled, then automatically loaded on the civicrm/a base page.

After

crmD3 module always exists, but is not automatically loaded on any base page. The crmMailingAB will load it as a dependency.

Technical Details

From the user's POV there is no change here. It just manages the Angular dependencies in a more standard, reusable way.

Comments

This is with an eye toward using D3 for Search Kit displays.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[totten]

This (REF) is a good idea. Now that we have conditional loading (basePages/requires), this looks much more sensible.

[seamuslee001]

I tested this saw there was no errors in the console log and also i see that the relevant code in the stats section

civicrm-core/ang/crmMailingAB/EditCtrl/report.html

Line 184 in 6f47e02

<div crm-ui-tab-set>

is commented out so I think this is fine to merge