Remove legacy check

[eileenmcnaughton]

Overview

Removes a check that dates right back to when we started extracting IPN code from code blocks in the processor. I don't believe it's meaningful

Before

Confusing check basically tells us whether the paymentProcessorID is loadable.

    if ($paymentProcessorID) {
      $paymentProcessor = CRM_Financial_BAO_PaymentProcessor::getPayment($paymentProcessorID,
        $this->is_test ? 'test' : 'live'
      );
      $ids['paymentProcessor'] = $paymentProcessorID;
      $this->_relatedObjects['paymentProcessor'] = $paymentProcessor;
    }

After

While we are not technically checking for it / loading now - there are multiple api calls that should fail if the processor_id is invalid - e.g when creating the financial transaction

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton needs a rebase