Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2205 - Deprecated function warning when choosing task from Find Cases results #19018

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/core/-/issues/2205

  1. Find Cases.
  2. Select some.
  3. Pick something from the actions dropdown.
  4. User deprecated function: Deprecated function CRM_Core_Form_Task::getTableName, use function should be overridden. Array ( [civi.tag] => deprecated ) in CRM_Core_Error_Log->log() (line 58 of .../CRM/Core/Error/Log.php).

User deprecated function: Deprecated function CRM_Core_Form_Task::getEntityAliasField, use function should be overridden. Array ( [civi.tag] => deprecated ) in CRM_Core_Error_Log->log() (line 58 of .../CRM/Core/Error/Log.php).

Before

After

Technical Details

Seems to be from here: https://github.com/civicrm/civicrm-core/pull/18783/files#diff-d3f50e6b56f73404b1de848be304c52ce8fbd3c126f120268778ea44ffb2dff8R305

Comments

@civibot
Copy link

civibot bot commented Nov 22, 2020

(Standard links)

@civibot civibot bot added the master label Nov 22, 2020
@seamuslee001
Copy link
Contributor

@demeritcowboy are you able to put this against 5.32 branch please given the other PR is in 5.32. Otherwise this works

@demeritcowboy demeritcowboy changed the base branch from master to 5.32 November 22, 2020 23:08
@civibot civibot bot added 5.32 and removed master labels Nov 22, 2020
@demeritcowboy
Copy link
Contributor Author

Ah, right. Thanks.

And now to fight with git...

@seamuslee001 seamuslee001 merged commit b1f8dbf into civicrm:5.32 Nov 23, 2020
@demeritcowboy demeritcowboy deleted the case-tasks-deprecated branch November 23, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants