dev/financial#152 remove determination of source #19017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
0352136 to
0fa584e
Compare
This function call determines the source, requiring quite a bit of complexity - however I believe it is unnecessary because either 1 ) we are completing an existing contribution - in which case the source will already exist or 2 ) we are repeating a contribution - in which case the source will be derived from the template contribution (with recurring appended). Removing this brings us close to the point where contribution is unnessary as an input parameter on the function
0fa584e to
2ca321f
Compare
|
@mattwire did you spot this one - basically I think there is a bunch of code here & in the functions that call completeOrder to prepare for this that seems of no value |
|
@mattwire what do you think on this one - it seems to me we can simplify here |
| @@ -45,6 +47,7 @@ public function createRepeatMembershipOrder() { | |||
| $orderID = $this->callAPISuccess('Order', 'create', [ | |||
| 'total_amount' => '200', | |||
| 'financial_type_id' => 'Donation', | |||
| 'source' => 'Online Contribution: form payment', | |||
There was a problem hiding this comment.
Test change is because the template contribution source is now used so we need to set it up in a valid/real-world sort of way - the source-is-empty-so-we-need-to-make-something-up is from an older flow IMHO
|
Yes, agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This removes a chunk of code used to determine the source to be given to a contribution in completeOrder because I believe it's extraneous
Either
1 ) we are completing an existing contribution - in which case the source will already exist or
2 ) we are repeating a contribution - in which case the source will be derived from the template contribution
(with recurring appended).
Before
lotsa code
After
poof
Technical Details
Removing this brings us close to the point where contribution is unnessary as an input parameter on the function
I believe the logic dates back to when this function was part of the IPN and it may have been necessary to create a new contribution because ... 4.x
Comments