dev/financial#152 [REF] Pass specific BAO into the recur function rather than the vague 'objects' #19016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an the vague 'objects'
|
(Standard links)
|
| @@ -84,8 +85,6 @@ public function recur($input, $ids, $objects, $first) { | |||
| return; | |||
| } | |||
|
|
|||
| $recur = &$objects['contributionRecur']; | |||
There was a problem hiding this comment.
Since objects was not received by reference & is never used again this reference is meaningless
|
Should have sufficient unit tests here and the code looks right to me MOP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor simplifcation of parameters for the recur function
Before
The 2 required objects are passed in an array $objects
After
The required objects are specified parameters
Technical Details
Comments