Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trait instead of class for Entity Bridges; add OptionList trait #19010

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

colemanw
Copy link
Member

Overview

Improves APIv4 categorization of entities, which is then used to improve the Search Kit UI.

Before

BridgeEntity is a class.
SearchKit shows all entities.

After

EntityBridge and OptionList are traits.
SearchKit list of entities excludes less useful ones.

Technical Details

Traits allow each entity to have > 1 type
This excludes both EntityBridge and OptionList types from the main search dropdown.

Traits allow each entity to have > 1 type
This excludes both EntityBridge and OptionList types from the
main search dropdown.
@civibot
Copy link

civibot bot commented Nov 21, 2020

(Standard links)

@civibot civibot bot added the master label Nov 21, 2020
@eileenmcnaughton
Copy link
Contributor

Rationale makes sense. Test cover is good here

@eileenmcnaughton eileenmcnaughton merged commit ad07104 into civicrm:master Nov 22, 2020
@eileenmcnaughton eileenmcnaughton deleted the bridges branch November 22, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants