Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APIv4 test to assert an exception is thrown #19009

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Fix APIv4 test to assert an exception is thrown #19009

merged 1 commit into from
Nov 21, 2020

Conversation

colemanw
Copy link
Member

Overview

Fixes an APIv4 unit test

Before

The test had only run its assertion in the catch block which would have been skipped if an exception wasn't thrown.

After

Test always asserts the exception is thrown as expected.

@colemanw
Fix APIv4 test to assert an exception is thrown
d34aa01 
The test had only run its assertion in the catch block which would have been skipped if an exception wasn't thrown
@civibot civibot bot added the master label Nov 21, 2020
@civibot
Copy link

civibot bot commented Nov 21, 2020

(Standard links)

@seamuslee001 seamuslee001 merged commit 8257f28 into civicrm:master Nov 21, 2020
@seamuslee001 seamuslee001 deleted the limitTest branch November 21, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @seamuslee001