dev/drupal#146 - Wrong link for Drupal 8 permissions page / Make CMS permissions url lookup more OO-ey #18986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
e4aa153 to
bc4824a
Compare
CRM/Utils/System/Base.php
Outdated
| * @return array | ||
| */ | ||
| public function getCMSPermissionsUrlParams() { | ||
| return NULL; |
There was a problem hiding this comment.
@demeritcowboy should this be an empty array instead of NULL?
There was a problem hiding this comment.
Thanks for looking. Yep that would be more consistent. Have updated.
|
I tested this on Drupal 7 and WordPress and both seem to be fine. One minor issue as I have raised otherwise looks good to merge IMO |
bc4824a to
839834b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/drupal/-/issues/146
At Administer - Users and Permissions - Permissions there's a link to the CMS's permissions page. It's wrong for drupal 8/9.
This started smaller but then I noticed backdrop was completely missing so figured I might as well do it right. So this moves the hardcoded CMS names code into their respective System subclasses.
Before
Drupal 8/9 link is wrong. Backdrop also wrong.
After
Right
Technical Details
OO
Comments