-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensionsuitweak #18981
Extensionsuitweak #18981
Conversation
(Standard links)
|
I think the actual change is a small tpl tweak that makes sense - I would note we have had some discussions about moving a community angular extension page extension into being a core extension as it seems like an improvement / leap from what we have and a better thing to build from (non blocking on this but @totten might like to comment) |
…the end-user rather than the developer
a0c8dfa
to
a015139
Compare
@seamuslee001 @eileenmcnaughton Sorry! Forgot to rebase out my local patches - now updated. |
So I think this is a pretty clear improvement. The only thing in here that is not just moving information around is the name is removed from the details pane - I assume the reasoning is that it is already in the top of the accordian. I don't have a strong opinion on that - would like to see a couple of +1s or creative emojis just to endorse that part of it |
@demeritcowboy was the link to github release policy intended? |
Just to explain what the emoji is about: http://shipitsquirrel.github.com/ |
Well in the spirit of recent important election results https://www.emoji.com/brand-icons/icons/kakapo+parrot-emoji-6625/ https://www.stuff.co.nz/environment/123404888/kkp-crowned-winner-of-bird-of-the-year-2020 |
Based on the feedback on this PR I'm going to add merge ready and if no one objects will merge in a couple of days |
Seems like a useful improvement to me. |
I agree - this change looks nice to me, and it's pretty small/safe. No need to block on the extension-management extension. |
Given all the supportive comments am going to merge this in |
Overview
As pointed out in https://lab.civicrm.org/extensions/stripe/-/issues/275 we are displaying information on the extensions UI in a way that is more helpful to developers than end-users.
Before
Name + extension key shown. Then in details name/key repeated and download location / local path at top.
After
Name + description shown. Then in details we don't show name/description again. We move more useful information (links/comments) to the top and less useful information towards the bottom (local path, key etc).
Technical Details
template change only.
Comments
I'm sure there are multiple opinions and multiple ways this could be improved further. Hopefully this is a good start :-)
@JoeMurray