dev/core#2155 Remove obscure broken handling for onlinePendingContribution

[eileenmcnaughton]

Overview

dev/core#2155 Remove obscure broken handling for onlinePendingContribution

Per https://lab.civicrm.org/dev/core/-/issues/2155 there is some obscure functionality for
completing a pending contribution under some cases. My testing suggests it is long-term broken.

Before

Update payment status appears in rare circumstances - seems to be long term broken

After

poof

Technical Details

See GL for discussion to date Per https://lab.civicrm.org/dev/core/-/issues/2155

Comments

View with the ?w=1 as some if -else has been removed - ie https://github.com/civicrm/civicrm-core/pull/18964/files?w=1

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@kcristiano if you have time to r-run the membership form & check it has no obvious breakage that would be amazing

[kcristiano]

@eileenmcnaughton I've given this an r-run on WP. It works as expected.

I did not know that the functionality was broken. I did have some clients using this function in the past, but based on the issue I think it's better out entirely. We can use an alternative workflow to update in the admin. I do think that the payment should be recorded on the Contribution and then if any membership changes are they can be done separately.

[seamuslee001]

Kevin has tested this and there doesn't appear to have been any objection in the Lab ticket merging