Remove always true if

[eileenmcnaughton]

Overview

Remove always true if

Before

if (!empty($contributionParams['contribution_recur_id'])) { is always true, but checked

After

Poof

Technical Details

By the time the code reaches this point contributionParams['contribution_recur_id']
must be set. We can confirm this by the fact the call to getTemplateContribution
requires id to be passed in and uses it in a lookup. Also the
code just before repeatTransaction ensures it is called

repeattransaction is called from only 1 place

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I think this is ok but would appreciate someone like @mattwire just confirming this is all good

[mattwire]

@eileenmcnaughton I wasn't sure about this. But tracing back the first lines of repeatTransaction:
if (!empty($contribution->id)) { return FALSE; }

prove that the entire function will not run if it was called via completeTransaction because the API call sets the contribution ID. And for repeatTransaction per earlier work we don't support calling without a recurring contribution ID.

[eileenmcnaughton]

Yep these things can take a bit of figuring out - but then the code is more ready for further changes...