Schema handler fixes #18932
Merged
Schema handler fixes #18932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the tableName lookup to use the method used throughout this class. The extra optimization (local caching in the $tables variable) was actually less efficient because CRM_Core_DAO::getFieldValue caches its results, and is used elsewhere so the value is likely to already be cached. The bug is that the same table name was repeatedly being passed into $logging->fixSchemaDifferencesFor().
|
(Standard links)
|
colemanw
commented
Nov 5, 2020
| @@ -145,7 +137,7 @@ public static function bulkSave($bulkParams, $defaults = []) { | |||
| $logging->fixSchemaDifferencesFor($tableName, ['ADD' => $addedColumns[$tableName]]); | |||
| } | |||
|
|
|||
| Civi::service('sql_triggers')->rebuild($params['table_name'], TRUE); | |||
| Civi::service('sql_triggers')->rebuild($tableName, TRUE); | |||
There was a problem hiding this comment.
@eileenmcnaughton this looks like it was a real bug to me.
There was a problem hiding this comment.
yes - it would have only updated one - probably in practice that was enough
| * @return bool | ||
| */ | ||
| public static function alterFieldSQL($params, $indexExist = FALSE, $triggerRebuild = TRUE) { | ||
| CRM_Core_Error::deprecatedFunctionWarning('function no longer in use / supported'); |
There was a problem hiding this comment.
Yep - deprecated Jul 2019
|
Cover in testBulkCreate() is adequate here & code makes sense so as long as tests pass all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates and a minor bug fix to custom field saving.
Before
Unused function hanging around.
Wrong param passed to
fixSchemaDifferencesFor().Overly complicated optimization that may have actually been less efficient.
After
Cleaner.