Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search ext: Fix validation and saving on search admin screen #18919

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 4, 2020

Overview

Improves form validation and fixes saving SavedSearches in Search Kit.
Gives better user feedback, fixes bugs and improves display style.

Comments

Also fixes a possible undefined variable error in crmError function.

@civibot
Copy link

civibot bot commented Nov 4, 2020

(Standard links)

@civibot civibot bot added the master label Nov 4, 2020
@eileenmcnaughton
Copy link
Contributor

Seems OK - will kick the tires on this work more thoroughly in the rc but this extension is still beta anyway

@eileenmcnaughton eileenmcnaughton merged commit fbb3855 into civicrm:master Nov 4, 2020
@eileenmcnaughton eileenmcnaughton deleted the searchKitValidate branch November 4, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants