Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Simplify use of shared code. #18900

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Before

Entry calls shared function transitionComponentWithReturnMessage but it throws away the return message

After

Entry calls shared function transitionComponents directly rather than via a shared function.

Technical Details

This function has been sharing 'transitionComponentWithStatusMessage' but in
fact it throws away the status message and the preliminary checks are silly.

This simplifies it so it calls the part of the function it actually does share

Comments

This function has been sharing 'transitionComponentWithStatusMessage' but in
fact it throws away the status message and the preliminary checks are silly.

This simplifies it so it calls the part of the function it actually does share
@civibot
Copy link

civibot bot commented Nov 2, 2020

(Standard links)

@civibot civibot bot added the master label Nov 2, 2020
@mattwire mattwire merged commit d8ff119 into civicrm:master Nov 2, 2020
@eileenmcnaughton eileenmcnaughton deleted the entry branch November 2, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants