dev/core#2147 Switch the groups search field on Simple search back fr…

[seamuslee001]

…om select2 to normal select

Overview

This fixes a the following bug https://lab.civicrm.org/dev/core/-/issues/2147 by switching this field back from Select2 to select.

Before

Select 2 field from #13958 back to a select field

After

Select field used

Technical Details

In select 2 the value is like 1 or 1,2 as a string. With a select is it [1] or [1, 2] as arrays

ping @eileenmcnaughton @monishdeb

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Ah - that makes sense - alternatively we could handle a bit more in BAO_Query_Group & instead of casting to an array we could explode to an array if not is_array

the line is

    foreach ((array) $value as $id) {

[eileenmcnaughton]

Just chatted with @seamuslee001 - given how close we are to release drop this seems a sensible approach although keeping the select 2 would be nicer