Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove always-true & otherwise silly if #18883

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 30, 2020

Overview

This if looked silly when it was commented as such & it still does

Before

 //?? how on earth would we not have component be one of these?
 // they are the only valid settings & this IPN file can't even be called without one of them
 // grepping for this class doesn't find other paths to call this class
 if ($this->_component == 'contribute' || $this->_component == 'event') {
    // do all the stuff 
 }

After

poof

Technical Details

The inner if is enough....

Comments

@civibot
Copy link

civibot bot commented Oct 30, 2020

(Standard links)

@civibot civibot bot added the master label Oct 30, 2020
@colemanw colemanw merged commit 834ba4a into civicrm:master Oct 30, 2020
@colemanw colemanw deleted the ppp branch October 30, 2020 13:23
@colemanw
Copy link
Member

Down with silly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants