[Ref] Use direct version of participant id #18882
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[Ref] Use direct version of participant id
Before
The value used for participantID is $participant->id which is derived from $ids['participantID]
After
Use $ids['participantID]
Technical Details
ids['Participant'] is taken from the url. It is then passed to loadRelatedObjects
where
civicrm-core/CRM/Contribute/BAO/Contribution.php
Line 2890 in 0bd5e6b
loads an object based on it. We then set ids too the object's id - which is a long way around to
using the paramter we started from. This does that
Comments