Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] Use direct version of participant id #18882

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 30, 2020

Overview

[Ref] Use direct version of participant id

Before

The value used for participantID is $participant->id which is derived from $ids['participantID]

After

Use $ids['participantID]

Technical Details

ids['Participant'] is taken from the url. It is then passed to loadRelatedObjects
where

$participant->id = $ids['participant'];

loads an object based on it. We then set ids too the object's id - which is a long way around to
using the paramter we started from. This does that

Comments

ids['Participant'] is taken from the url. It is then passed to loadRelatedObjects
where
https://github.com/civicrm/civicrm-core/blob/0bd5e6bfbe8f339dbe066e3e96e00760c93a57e2/CRM/Contribute/BAO/Contribution.php#L2890
loads an object based on it. We then set ids too the object's id - which is a long way around to
using the paramter we started from. This does that
@civibot
Copy link

civibot bot commented Oct 30, 2020

(Standard links)

@civibot civibot bot added the master label Oct 30, 2020
@mattwire mattwire merged commit c9f4ab4 into civicrm:master Nov 1, 2020
@eileenmcnaughton eileenmcnaughton deleted the pps branch November 1, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants