Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participant Calculate/Fees: fix ts usage, simplify wording #18874

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Oct 29, 2020

Overview

Fixes an incorrect use of ts, which assumes how strings can be concatenated. It also makes it difficult to use Word Replacements.

Capture d’écran de 2020-10-29 14-38-41

After:

Capture d’écran de 2020-10-29 15-05-15

Comments

I wanted to override the wording to simplify display "Total". It was not possible because of how the strings are concatenated.

Using wording such as "Fee(s)" really looks clunky, but will avoid changing the priceset title for now.

@civibot
Copy link

civibot bot commented Oct 29, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Seems fine to me - simpler & more generic is better IMHO

@eileenmcnaughton eileenmcnaughton merged commit 538388a into civicrm:master Oct 29, 2020
@eileenmcnaughton eileenmcnaughton deleted the totalParticipantTs branch October 29, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants