Participant Calculate/Fees: fix ts usage, simplify wording #18874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an incorrect use of
ts
, which assumes how strings can be concatenated. It also makes it difficult to use Word Replacements.After:
Comments
I wanted to override the wording to simplify display "Total". It was not possible because of how the strings are concatenated.
Using wording such as "Fee(s)" really looks clunky, but will avoid changing the priceset title for now.