dev/core#2115 Move filtering of unpermitted options for reports/ search select to financialacl extension

[eileenmcnaughton]

Overview

Builds on #18848 & should be rebased once that is merged

Before

Use of specific function

 'options' => CRM_Financial_BAO_FinancialType::getAvailableFinancialTypes(),

After

Generic function with hook

 'options' =>  CRM_Contribute_BAO_Contribution::buildOptions('financial_type_id', 'search'),

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton can you rebase?

[seamuslee001]

unless it is already

[eileenmcnaughton]

thanks @seamuslee001 done now. As an aside I think ideally extended reports & the IATs report would get the same updates once agreed. There are some other places in Civi too but they were not as obviously straightforward