Get phone_type by name. dev/core#2138 #18842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Core/BAO/Phone.php
Outdated
| @@ -92,7 +92,8 @@ public static function allPhones($id, $updateBlankLocInfo = FALSE, $type = NULL, | |||
|
|
|||
| $cond = NULL; | |||
| if ($type) { | |||
| $phoneTypeId = array_search($type, CRM_Core_PseudoConstant::get('CRM_Core_DAO_Phone', 'phone_type_id')); | |||
| $phoneTypes = CRM_Core_OptionGroup::values('phone_type', TRUE, FALSE, FALSE, NULL, 'name'); | |||
| $phoneTypeId = CRM_Utils_Array::value($type, $phoneTypes); | |||
There was a problem hiding this comment.
I'm not sure what the latest standard is but I think it would be preferred to replace both these lines with $phoneTypeId = CRM_Core_PseudoConstant::getKey('CRM_Core_DAO_Phone', 'phone_type_id', $type). In any case CRM_Utils_Array::value is discouraged in places where you can use $a[$b] ?? NULL instead.
There was a problem hiding this comment.
Yes -
$phoneTypeId = CRM_Core_PseudoConstant::getKey('CRM_Core_DAO_Phone', 'phone_type_id', $type);
is the preferred syntax for this
|
Thanks @demeritcowboy and @eileenmcnaughton . I have updated the code. |
|
|
Nice - thanks @muniodiego @demeritcowboy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When wanting to send an SMS, a mobile phone is not identified if it is not primary and if the label of the mobile phone type has been translated or modifed.