Set id after save for the mailing component in the postProcess

[jvos]

Overview

After save the mailing component (Headers, Footers, and Automated Messages) the id is set in the postProcess.

Before

After save of the mailing component the id is not set.

After

Now the id is set after the mailing component is saved.

Technical Details

The id is set after save $this->_id = $component->id;

Comments

No comments.

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins test this please

[eileenmcnaughton]

Can you please add a code comment as to why? I'm guessing it's for extension support & it could be 'tidied up' if it's point is not clear

[jvos]

It's easier to use the posProcess hook in a extension that the id is set after the mailing component (Headers, Footers, and Automated Messages) is saved

[eileenmcnaughton]

@jvos - I mean a comment in the code - for future us

[eileenmcnaughton]

Also - that red x - is style warnings - https://test.civicrm.org/job/CiviCRM-Core-PR/37568/

[eileenmcnaughton]

Thanks for the comment - you having quite won the battle with our style checker yet

[eileenmcnaughton]

@jvos are you able to do one last thing & squash the commits down to 1? You need to do a force push (git push -f ) to push the change up

[eileenmcnaughton]

thanks! One last task - can your PR yourself into Contributors.yml

https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml

[jvos]

It's was a battle bot i won ;) Thanks for your patience!