dev/core#2043 Remove instance of pass-by-ref #18802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Test fails relate I believe |
4cb857f to
bcffe90
Compare
|
@eileenmcnaughton Needs rebase |
The postProcess function onlly uses one value generated in the private function processMembersip. This makes that a return value rather than something hidden in the pass-by-ref
bcffe90 to
818f20f
Compare
|
thanks - done |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove problematic coding practice per
https://lab.civicrm.org/dev/core/-/issues/2043
Before
'hidden' return property is added to pass-by-ref params
After
Return property returned
Technical Details
The postProcess function only uses one value generated in the private function
processMembership. This makes that a return value rather than something hidden in
the pass-by-ref
Test cover
CRM_Batch_Form_EntryTest.testProcessMembership with data set #0
CRM_Batch_Form_EntryTest.testProcessMembership with data set #1
CRM_Batch_Form_EntryTest.testMembershipRenewalDates