Remove always true if

[eileenmcnaughton]

Overview

Follow on to #18790 - remove always-true IF

Before

Code wrapped in if ($paymentProcessorObj) { - but that will always be true as the manual processor is returned if no id

After

poof

Technical Details

Since paymentProcessorObj is loaded as the manual processor where another does not exist
the processor condition is always true - so this if is obsolete

Comments

This is in it's own PR for whitespace readability reasons - the other IF should also be obsolete so that would be the next follow up

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton what happens if CRM_Contribute_BAO_ContributionRecur::getPaymentProcessorID($recurID) can't find a PaymentProcessorID?

[eileenmcnaughton]

@seamuslee001 Civi\Payment\System::singleton()->getById will return the manual processor if id is empty

[seamuslee001]

Looks fine to me then merging