CPS-332: Button markup fix in PremiumBlock.tpl #18799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
reneolivo
approved these changes
Oct 19, 2020
| @@ -62,7 +62,9 @@ | |||
| <div class="premium-full-title">{$row.name}</div> | |||
| <div class="premium-full-disabled"> | |||
| {ts 1=$row.min_contribution|crmMoney}You must contribute at least %1 to get this item{/ts}<br/> | |||
| <button type="button" value="{ts 1=$row.min_contribution|crmMoney}Contribute %1 Instead{/ts}" amount="{$row.min_contribution}" /> | |||
| <button class="btn btn-secondary" type="button" amount="{$row.min_contribution}"> | |||
There was a problem hiding this comment.
I wasn't aware we were putting in bootstrap classes here? should we be using crm-button class instead?
There was a problem hiding this comment.
Good point. I removed the classes and it still works.
|
@deb1990 is this still WIP per the title? |
|
@eileenmcnaughton I have moved it out of WIP now. |
|
I'm going to merge this - I think waiting for @agh1 to weigh in is less important than getting known button issues fixed in the rc to make it solid for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In https://github.com/civicrm/civicrm-core/pull/18410/files#diff-6b993747c85ceec4b537726331c934f4aeac58a54152f850dab5aec2942a1009L65, the button markup was not fixed correctly, so this PR fixes the same.
Before
After