Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to calling the api #18796

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Switch to calling the api #18796

merged 1 commit into from
Oct 19, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Switches from direct BAO Membership::create to api in tested code place

Before

CRM_Member_BAO_Membership::create($params);

After

civicrm_api3('Membership', 'create', $params);

Technical Details

Working on getting rid of direct BAO calls as a step towards cleaning up the Membership create function so we can sort out v4

Comments

Test cover in
api_v3_ContactTest.testMergeOrganizations

Test cover in
api_v3_ContactTest.testMergeOrganizations
@civibot
Copy link

civibot bot commented Oct 19, 2020

(Standard links)

@civibot civibot bot added the master label Oct 19, 2020
@colemanw colemanw merged commit 55a8fe1 into civicrm:master Oct 19, 2020
@colemanw colemanw deleted the api3 branch October 19, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants