dev/core#2125 Ensure that the id that is used in the field is the gro… #18776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up id not the id of array key as that has changed from being a keyed array to a 2D array
|
(Standard links)
|
|
OK - is @monishdeb able to check this as he worked on this |
|
On quick look, its definitely what's needed here. Unfortunately during a thorough review #13958 didn't catch this miss of fetching id from the code. Also on the 2nd round of the fixes in another PR. Tested on my local and looks good. |
monishdeb
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…up id not the id of array key as that has changed from being a keyed array to a 2D array
Overview
This fixes an issue where by the group id is no longer used as part of the field name and as such can cause DB errors when submitting the form
Before
Possible DB errors because group id my not exist
After
No DB Errors
Technical Details
It would seem as tho in 78d0090#diff-c113d6099b62e0ddbf3876a74fbf756f7743590dd27397dec4ebf9b24dfca578R1126 the hierarchy array changed from being keyed on the group id to just a sequential array which meant that $id in this no longer matched up to the group id from civicrm_group table
https://lab.civicrm.org/dev/core/-/issues/2125
ping @eileenmcnaughton